Migrate helloworld to use {usesCleartextTraffic} manifest placeholder
#52647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78425139 |
…facebook#52620) Summary: This creates a `debugOptimized` build type for React Native Android, meaning that we can run C++ optimization on the debug build, while still having the debugger enabled. This is aimed at improving the developer experience for folks developing on low-end devices or emulators. Users that intend to debug can still use the `debug` variant where the full debug symbols are shipped. ## Changelog: [ANDROID] [ADDED] - Create a debugOptimized buildType for Android Pull Request resolved: facebook#52620 Test Plan: Tested locally with RNTester by doing: ``` ./gradlew installDebugOptimized ``` This is the output of the 3 generated .aar. The size difference is a proof that we're correctly stripping out the C++ debug symbols: <img width="193" height="54" alt="Screenshot 2025-07-15 at 17 49 50" src="https://github.com/user-attachments/assets/584a0e8d-2d17-40d4-ac29-da09049d6554" /> <img width="235" height="51" alt="Screenshot 2025-07-15 at 17 49 39" src="https://github.com/user-attachments/assets/eda8f9e7-3509-4334-8c16-990e55caa04d" /> <img width="184" height="52" alt="Screenshot 2025-07-15 at 17 49 32" src="https://github.com/user-attachments/assets/a5c94385-bc00-4484-b43e-088ee039827f" /> Differential Revision: D78351347 Reviewed By: cipolleschi Pulled By: cipolleschi
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78425139 |
cortinico
force-pushed
the
export-D78425139
branch
from
d6e221d to
1928adc
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Jul 18, 2025
…er (facebook#52647) Summary: Pull Request resolved: facebook#52647 This removes the need to specify 2 Manifests for apps and we can just use the `main` manifes to toggle if `usesCleartextTraffic` should be enabled or not. This will have to be replicated in the template repository. Changelog: [Android] [Added] - Add support to specify a single Manifest rather than 2 (main/debug) by using the `usesCleartextTraffic` manifest placeholder which is autoconfigured by RNGP. Reviewed By: cipolleschi Differential Revision: D78425139
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78425139 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Jul 18, 2025
…er (facebook#52647) Summary: Pull Request resolved: facebook#52647 This removes the need to specify 2 Manifests for apps and we can just use the `main` manifes to toggle if `usesCleartextTraffic` should be enabled or not. This will have to be replicated in the template repository. Changelog: [Android] [Added] - Add support to specify a single Manifest rather than 2 (main/debug) by using the `usesCleartextTraffic` manifest placeholder which is autoconfigured by RNGP. Reviewed By: cipolleschi Differential Revision: D78425139
cortinico
force-pushed
the
export-D78425139
branch
from
1928adc to
7c4c758
Compare
…er (facebook#52647) Summary: Pull Request resolved: facebook#52647 This removes the need to specify 2 Manifests for apps and we can just use the `main` manifes to toggle if `usesCleartextTraffic` should be enabled or not. This will have to be replicated in the template repository. Changelog: [Android] [Added] - Add support to specify a single Manifest rather than 2 (main/debug) by using the `usesCleartextTraffic` manifest placeholder which is autoconfigured by RNGP. Reviewed By: cipolleschi Differential Revision: D78425139
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78425139 |
cortinico
force-pushed
the
export-D78425139
branch
from
7c4c758 to
0c46c4b
Compare
Contributor
|
This pull request has been merged in d89acc1. |
kikoso
pushed a commit
to kikoso/react-native
that referenced
this pull request
Aug 26, 2025
…er (facebook#52647) Summary: Pull Request resolved: facebook#52647 This removes the need to specify 2 Manifests for apps and we can just use the `main` manifes to toggle if `usesCleartextTraffic` should be enabled or not. This will have to be replicated in the template repository. Changelog: [Android] [Added] - Add support to specify a single Manifest rather than 2 (main/debug) by using the `usesCleartextTraffic` manifest placeholder which is autoconfigured by RNGP. Reviewed By: cipolleschi Differential Revision: D78425139 fbshipit-source-id: 9173a014b387d5aed5f7087fa69b7bd49c220f2c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This removes the need to specify 2 Manifests for apps and we can just use the
mainmanifes to toggle ifusesCleartextTrafficshould be enabled or not.This will have to be replicated in the template repository.
Changelog:
[Android] [Added] - Add support to specify a single Manifest rather than 2 (main/debug) by using the
usesCleartextTrafficmanifest placeholder which is autoconfigured by RNGP.Differential Revision: D78425139